aboutsummaryrefslogtreecommitdiff
path: root/slave.c
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2023-05-12 12:55:55 +0000
committerDaniel Eklöf <daniel@ekloef.se>2023-05-18 15:50:48 +0000
commita2f765b72a6612758a034a5b0c24ec08625db1a3 (patch)
treeb6c58f68f43b2b246a3b47992da3e021ffe44974 /slave.c
parentcustomized gnome-like csd buttons (diff)
slave: unset TERM_PROGRAM{,_VERSION}
Foot’s policy is to not set environment variables that identifies it (except the well-known and established `TERM` variable). We encourage applications to use terminfo to determine capabilities, or terminal queries, when available. Or, at least use terminal queries to detect the terminal and its version. Setting environment variables is a bad idea since they are inherited by all applications started by the terminal (which is the whole point). But, this includes other terminal emulators, making it very possible a terminal emulator gets mis-detected just because it was started from another terminal. Since there are a couple of terminal emulators that _do_ set TERM_PROGRAM and TERM_PROGRAM_VERSION, unset these environment variables to avoid being misdetected. Closes #1349
Diffstat (limited to 'slave.c')
-rw-r--r--slave.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/slave.c b/slave.c
index 2f23e996..ecfce7e6 100644
--- a/slave.c
+++ b/slave.c
@@ -21,7 +21,6 @@
#include "macros.h"
#include "terminal.h"
#include "tokenize.h"
-#include "version.h"
#include "xmalloc.h"
extern char **environ;
@@ -352,11 +351,12 @@ slave_spawn(int ptmx, int argc, const char *cwd, char *const *argv,
}
setenv("TERM", term_env, 1);
- setenv("TERM_PROGRAM", "foot", 1);
- setenv("TERM_PROGRAM_VERSION", FOOT_VERSION_SHORT, 1);
setenv("COLORTERM", "truecolor", 1);
setenv("PWD", cwd, 1);
+ unsetenv("TERM_PROGRAM");
+ unsetenv("TERM_PROGRAM_VERSION");
+
#if defined(FOOT_TERMINFO_PATH)
setenv("TERMINFO", FOOT_TERMINFO_PATH, 1);
#endif