aboutsummaryrefslogtreecommitdiff
path: root/slave.h
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2024-01-09 15:50:47 +0000
committerDaniel Eklöf <daniel@ekloef.se>2024-01-11 15:37:17 +0000
commit9da7152f834384a354710fcc8f99a6f83e5dfc12 (patch)
treed5dffcbe9133d87a034bf32d09b3ef25f4ddc610 /slave.h
parentconfig: fix cloning of env_vars tllist (diff)
slave: don't skip setting environment variables when using a custom environment
When launching footclient with -E,--client-environment the environment variables that should be set by foot, wasn't. Those variables are: * TERM * COLORTERM * PWD * SHELL and all variables defined by the user in the [environment] section in foot.ini. In the same way, we did not *unset* TERM_PROGRAM and TERM_PROGRAM_VERSION. This patch fixes it by "cloning" the custom environment, making it mutable, and then adding/removing the variables above from it. Instead of calling setenv()/unsetenv() directly, we add the wrapper functions add_to_env() and del_from_env(). When *not* using a custom environment, they simply call setenv()/unsetenv(). When we *are* using a custom environment, add_to_env() first loops all existing variables, looking for a match. If a match is found, it's updated with the new value. If it's not found, a new entry is added. del_from_env() loops all entries, and removes it when a match is found. If no match is found, nothing is done. The mutable environment is allocated on the heap, but never free:d. We don't need to free it, since it's only allocated after forking, in the child process. Closes #1568
Diffstat (limited to 'slave.h')
-rw-r--r--slave.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/slave.h b/slave.h
index b1c08f14..26d93abb 100644
--- a/slave.h
+++ b/slave.h
@@ -7,7 +7,7 @@
#include "user-notification.h"
pid_t slave_spawn(
- int ptmx, int argc, const char *cwd, char *const *argv, char *const *envp,
+ int ptmx, int argc, const char *cwd, char *const *argv, const char *const *envp,
const env_var_list_t *extra_env_vars, const char *term_env,
const char *conf_shell, bool login_shell,
const user_notifications_t *notifications);