aboutsummaryrefslogtreecommitdiff
path: root/terminal.c
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2020-10-29 17:06:04 +0000
committerDaniel Eklöf <daniel@ekloef.se>2020-11-06 19:08:52 +0000
commit273f105af5861e35f58b6a37e9b1b576dd9adaec (patch)
tree8fd91d7a80e35fb1c939b28ce5f3ec896e59a068 /terminal.c
parentmain: remove trailing ‘, ’ from arch log line (diff)
tiocswinsz: fix compilation error on e.g. ppc64
On some platforms, TIOCSWINSZ has a very large value, > 0x80000000. On some platforms, the `request` argument to `ioctl(3)` is an `int`. For platforms where both of the above is true, gcc will warn (and error out if compiled with `-Werror`) on: ioctl(fd, TIOCSWINSZ, ...) To silence this warning, we need to cast `TIOCSWINSZ` to an integer. However, doing this on platforms where `request` is an `unsigned long` will result in `TIOCSWINSZ` being sign-extended (and thus we end up with an invalid value). It seems that casting to `unsigned int` works in both cases; it silences the long -> int conversion warning, while also preserving the correct value in all cases.
Diffstat (limited to 'terminal.c')
-rw-r--r--terminal.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/terminal.c b/terminal.c
index f931ba7d..4651fc1a 100644
--- a/terminal.c
+++ b/terminal.c
@@ -883,7 +883,7 @@ term_init(const struct config *conf, struct fdm *fdm, struct reaper *reaper,
goto close_fds;
}
- if (ioctl(ptmx, TIOCSWINSZ,
+ if (ioctl(ptmx, (unsigned int)TIOCSWINSZ,
&(struct winsize){.ws_row = 24, .ws_col = 80}) < 0)
{
LOG_ERRNO("failed to set initial TIOCSWINSZ");