aboutsummaryrefslogtreecommitdiff
path: root/terminal.h
diff options
context:
space:
mode:
authorDaniel Eklöf <daniel@ekloef.se>2023-06-16 14:26:13 +0000
committerDaniel Eklöf <daniel@ekloef.se>2023-06-16 14:26:13 +0000
commitd88bea5e22330c36c241ae0d441279799ac5897f (patch)
treee80f000fe6f6b409311bb05d1d540b7db3b2ed4a /terminal.h
parenttest: config: add test for url.protocols option (diff)
vt: split up action_param() to three separate functions
We’re already switching on the next VT input byte in the state machine; no need to if...else if in action_param() too. That is, split up action_param() into three: * action_param_new() * action_param_new_subparam() * action_param() This makes the code cleaner, and hopefully slightly faster. Next, to improve performance further, only check for (sub)parameter overflow in action_param_new() and action_param_subparam(). Add pointers to the VT struct that points to the currently active parameter and sub-parameter. When the number of parameters (or sub-parameters) overflow, warn, and then point the parameter pointer to a "dummy" value in the VT struct. This way, we don’t have to check anything in action_param().
Diffstat (limited to 'terminal.h')
-rw-r--r--terminal.h8
1 files changed, 6 insertions, 2 deletions
diff --git a/terminal.h b/terminal.h
index d2762a5a..abedf44d 100644
--- a/terminal.h
+++ b/terminal.h
@@ -180,8 +180,10 @@ struct grid {
};
struct vt_subparams {
- unsigned value[16];
uint8_t idx;
+ unsigned *cur;
+ unsigned value[16];
+ unsigned dummy;
};
struct vt_param {
@@ -197,8 +199,10 @@ struct vt {
#endif
char32_t utf8;
struct {
- struct vt_param v[16];
uint8_t idx;
+ struct vt_param *cur;
+ struct vt_param v[16];
+ struct vt_param dummy;
} params;
uint32_t private; /* LSB=priv0, MSB=priv3 */