aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeLines
* csi: xtsave/xtrestore: implement \E[?12s and \E[?12rDaniel Eklöf2020-08-18-3/+19
| | | | I.e. save/restore cursor-blink state.
* csi: decset/decrst: only clear mouse tracking/reporting if mode matchesDaniel Eklöf2020-08-18-9/+24
| | | | | | | | E.g. only set mouse reporting to NONE, if mouse reporting mode is SGR and an DECRST SGR is issued. Do *not* reset the mouse mode if e.g. mouse reporting mode is SGR and an DECRST URXVT is issued.
* changelog: xtsave/xtrestoreDaniel Eklöf2020-08-16-0/+2
|
* csi: implement XTRESTOREDaniel Eklöf2020-08-16-16/+34
|
* term: xtsave: store state in a bitfieldDaniel Eklöf2020-08-16-20/+20
| | | | | These shouldn't be accessed in any performance critical paths, so lets save some memory and use a bitfield.
* csi: xtsave: store modes' SET state, not the current stateDaniel Eklöf2020-08-16-22/+25
|
* csi: implement CSI ? Pm s - XTSAVEDaniel Eklöf2020-08-16-16/+2
|
* csi: add xtsave()Daniel Eklöf2020-08-16-6/+58
| | | | This function stores the current state of DECSET private modes.
* csi: decrst: spell decset correctlyDaniel Eklöf2020-08-16-1/+1
|
* csi: add DEC names to a couple of DECSET modesDaniel Eklöf2020-08-16-1/+6
|
* csi: break out decset/decrstDaniel Eklöf2020-08-16-274/+206
|
* Merge branch 'spelling-fix' into masterDaniel Eklöf2020-08-16-1/+1
|\
| * Fix spelling mistake in vt.cCraig Barnes2020-08-16-1/+1
|/
* changelog: add ordoviz to contributorsDaniel Eklöf2020-08-16-0/+1
|
* Merge branch 'typos' into masterDaniel Eklöf2020-08-16-6/+6
|\
| * Fix typosLennard Hofmann2020-08-15-6/+6
|/
* Merge branch 'spelling-fixes' into masterDaniel Eklöf2020-08-15-12/+12
|\
| * Fix some spelling mistakesCraig Barnes2020-08-15-12/+12
| |
* | Merge branch 'typo' into masterDaniel Eklöf2020-08-15-1/+1
|\ \ | |/ |/|
| * Fix typoBirger Schacht2020-08-15-1/+1
|/
* readme: ctrl+shift+n: add link to wikiDaniel Eklöf2020-08-15-3/+4
|
* changelog: remove duplicate entries (caused by bad merge)Daniel Eklöf2020-08-14-4/+0
|
* render: render the render timer *before* committing the main surfaceDaniel Eklöf2020-08-14-17/+17
|
* render: render-timer: position sub-surface similar to the scrollback indicatorDaniel Eklöf2020-08-14-1/+5
|
* Merge branch 'mouse-binding-actions' into masterDaniel Eklöf2020-08-14-53/+160
|\ | | | | | | Closes #79. Closes #75.
| * input: mouse motion: don't update selection while scrollback searchingDaniel Eklöf2020-08-14-2/+4
| | | | | | | | | | When we are doing a scrollback search, the selection *is* ongoing. We still don't want to update the selection when the mouse moves.
| * input: bindings: calculate 'cursor_is_on_grid' once onlyDaniel Eklöf2020-08-14-18/+8
| |
| * footrc: fix combo for select-begin-blockDaniel Eklöf2020-08-14-1/+1
| | | | | | | | Typo: should be a '+', not a '='.
| * input: mouse-bindings: ignore ShiftDaniel Eklöf2020-08-14-3/+9
| | | | | | | | | | | | | | | | Shift is used to enable selection when the client application is grabbing the mouse. As such, mouse bindings *never* have Shift as a modifier, but should still trigger when Shift is being pressed.
| * config: don't allow Shift in mouse bindingsDaniel Eklöf2020-08-14-0/+9
| | | | | | | | | | Shift is a special modifier that is used to enable selection when the client application is grabbing the mouse.
| * input: mouse-bindings: check selection is enabled/possible and that pointer is on gridDaniel Eklöf2020-08-14-13/+33
| | | | | | | | | | | | | | | | | | | | We shouldn't start or modify a selection if selection isn't possible (i.e. client application is grabbing the mouse, and user isn't holding Shift). We also shouldn't start or modify a selection if the pointer is outside the grid (updating an ongoing selection on motion events is an exception to this).
| * doc: footrc: mouse-bindings: clean up descriptionDaniel Eklöf2020-08-14-14/+10
| |
| * changelog: new mouse actionsDaniel Eklöf2020-08-14-0/+6
| |
| * config: mouse bindings: add select-begin-block and select-rowDaniel Eklöf2020-08-14-19/+40
| |
| * selection: extend: set ongoing to trueDaniel Eklöf2020-08-14-0/+2
| |
| * selection: finalize: clear ongoing selectionDaniel Eklöf2020-08-14-3/+3
| | | | | | | | | | | | | | | | | | | | Check for ongoing selection, and *clear* it before bailing out due to the selection not having an end-point. This fixes an issue where a selection was kept as ongoing, even though the button had been released. Typically triggered by clicking without moving the mouse; this started a new selection, then (tried to) finalize it, but failed since the selection didn't have an end-point.
| * selection: update: don't update if there's no ongoing selectionDaniel Eklöf2020-08-14-0/+3
| |
| * doc: footrc: document the new mouse actionsDaniel Eklöf2020-08-14-0/+18
| |
| * config: add mouse specific bind actionsDaniel Eklöf2020-08-14-38/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This extends the "normal" bind action enum with mouse specific actions. When parsing key bindings, we only check up to the last valid keyboard binding, while mouse bindings support *both* key actions and mouse actions. The new actions are: * select-begin: starts an interactive selection * select-extend: interactively extend an existing selection * select-word: select word under cursor * select-word-whitespace: select word under cursor, where the only word separating characters are whitespace characters. The old hard-coded selection "bindings" have been converted to instead use these actions, via default bindings added to the configuration.
| * changelog: click count in mouse bindingsDaniel Eklöf2020-08-14-0/+2
| |
| * changelog: modifier support in mouse bindingsDaniel Eklöf2020-08-14-0/+2
|/
* Merge branch 'click-count-in-mouse-bindings' into masterDaniel Eklöf2020-08-14-32/+65
|\ | | | | | | Closes #78
| * changelog: click count in mouse bindingsDaniel Eklöf2020-08-14-0/+2
| |
| * doc: footrc: document click count in mouse bindingsDaniel Eklöf2020-08-14-3/+12
| |
| * config: mouse bindings: add support for click countDaniel Eklöf2020-08-14-2/+26
| | | | | | | | Specified by appending "-X", where X is a number.
| * config: wrap LOG_AND_NOTIFY_*() in do {} while (0)Daniel Eklöf2020-08-14-27/+25
|/ | | | This allows us to use these macros in if-statement without braces.
* Merge branch 'modifiers-in-mouse-bindings' into masterDaniel Eklöf2020-08-14-318/+589
|\
| * doc: footrc: document modifiers in mouse bindingsDaniel Eklöf2020-08-13-3/+5
| |
| * changelog: modifier support in mouse bindingsDaniel Eklöf2020-08-13-0/+2
| |
| * config: key/mouse bindings: refactor: less parsing in keyboard_enter()Daniel Eklöf2020-08-13-443/+524
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This simplifies the handling of mouse and keyboard bindings. Before, the bindings where parsed *both* when loading the configuration, and then on every keyboard enter event. This was done since keys require a keymap to be decoded. Something we don't have at configuration time. The idea was that at config time, we used a default keymap just to verify the key combo strings were valid. The following has changed: * The bindings in the config struct is now *one* key combo per entry. Previously, it was one *action* per entry, and each entry had one or more key combos. Doing it this way makes it easier when converting the binding in the keyboard enter event (which previously had to expand the combos anyway). * The bindings in the config struct no longer contains any unparsed strings. A key binding contains a decoded 'modifier' struct (which specifies whether e.g. ctrl, or shift, or ctrl+shift must be pressed for the binding to be used). It also contains a decoded XKB keysym. * A mouse binding in the config struct is similar to a key binding, except it contains the button, and click count instead of the XKB key sym. * The modifiers in the user-specified key combo is decoded at config time, by using the pre-defined XKB constants XKB_MOD_NAME_<modifier>. The result is stored in a 'modifiers' struct, which is just a collection of booleans; one for each supported modifier. The supported modifiers are: shift, ctrl, alt and meta/super. * The key sym is decoded at config time using xkb_keysym_from_name(). This call does *not* depend on a keymap. * The mouse button is decoded at config time using a hardcoded mapping table (just like before). * The click count is currently hard-coded to 1. * In the keyboard enter event, all we need to do is pre-compute the xkb_mod_mask_t variable for each key/mouse binding, and find all the *key codes* that map to the (already decoded) symbol. For mouse bindings, the modifiers are the *only* reason we convert the mouse bindings at all. In fact, on button events, we check if the seat has a keyboard. If not, we use the mouse bindings from the configuration directly, and simply filter out those with a non-empty set of modifiers.
| * input: pointer-leave: don't reset mouse properties with memset()Daniel Eklöf2020-08-13-1/+6
| | | | | | | | | | Using memset() also clears the mouse bindings. This is both incorrect, and leaked memory.
| * wayland: global-remove: return after finding a matching seatDaniel Eklöf2020-08-13-0/+1
| |
| * wayland: global-remove: fix call to pointer_listener.leave()Daniel Eklöf2020-08-13-5/+9
| | | | | | | | | | Don't call it when we have keyboard focus, call it when we have mouse focus.
| * config: wip: add support for modifiers in mouse bindingsDaniel Eklöf2020-08-13-31/+207
| | | | | | | | | | | | | | Mouse bindings can now include modifiers. They are specified in pretty much the same way as in keyboard bindings: Control+BTN_LEFT
* | input: don't crash on mouse motion events on the render timer surfaceDaniel Eklöf2020-08-14-1/+8
|/
* render: oops... swprintf() needs to number of *chars*, not *bytes*Daniel Eklöf2020-08-13-1/+1
|
* render: fix printf-errors in 32-bit buildsDaniel Eklöf2020-08-13-2/+3
|
* config: add tweak.render-timer optionDaniel Eklöf2020-08-13-55/+158
| | | | | | | | | This can be set to 'none' (the default), 'osd', 'log' or 'both'. When 'osd' is enabled, we'll render the frame rendering time to a sub-surface after each frame. When 'log' is enabled, the frame rendering time is logged on stderr.
* doc: footclient.1: move DESCRIPTION up before OPTIONSDaniel Eklöf2020-08-13-10/+10
|
* doc: foot.1: move DESCRIPTION up before OPTIONSDaniel Eklöf2020-08-13-10/+10
|
* selection: improve handling of multi-column charactersDaniel Eklöf2020-08-13-13/+14
| | | | | * Don't assume multi-column characters are exactly *two* columns * Check for CELL_MULT_COL_SPACER values instead of using wcwidth()
* selection: handle multi-column characters when reversing selection directionDaniel Eklöf2020-08-13-16/+30
|
* changelog: cancelling -> cancelingDaniel Eklöf2020-08-13-1/+1
|
* Merge branch 'selection-inversion' into masterDaniel Eklöf2020-08-13-0/+41
|\
| * selection: adjust start point when the selection changes directionDaniel Eklöf2020-08-12-0/+41
| | | | | | | | | | | | | | | | | | Without this, the initial cell will always be selected, regardless of how the selection is moved to the left or right. With this patch, the initial cell will only be selected while the selection is being made in the original direction. Changing direction of the selection moves the start point to next/previous character.
* | Merge branch 'custom-selection-colors' into masterDaniel Eklöf2020-08-13-8/+33
|\ \ | |/ |/|
| * config: make selection foreground/background colors configurableDaniel Eklöf2020-08-12-8/+33
|/ | | | | | | | | The default is still to inverse the regular foreground/background colors. If the user sets *both* of the new options, selection-foreground and selection-background, those colors will *always* be used for selected cells, instead of inverting the regular foreground/background colors.
* doc: foot.1: don't talk about using '--' on the command lineDaniel Eklöf2020-08-12-3/+2
| | | | This used to be necessary, but isn't anymore.
* search: don't update/refresh match when modifier keys are pressedDaniel Eklöf2020-08-12-0/+3
|
* search: fix viewport not moving if we tried to move it past the scrollback startDaniel Eklöf2020-08-12-21/+57
| | | | | | | | | | | | If the match was somewhere near the scrollback beginning, and if the entire scrollback hadn't yet been filled, we ended up trying to move the viewport past the beginning of the scrollback, which we then adjusted in the wrong direction, causing the viewport to not move at all. Besides being a bad user experience, since the new match wasn't visible, foot would also crash if you manually scrolled up to the match.
* Revert "ci: sr.ht: just testing..."Daniel Eklöf2020-08-11-2/+2
| | | | This reverts commit b7b7b56b3d64d1eca008082331d94eecfd60dfdf.
* ci: sr.ht: just testing...Daniel Eklöf2020-08-11-2/+2
|
* render: fix compilation errors in 32-bit buildsDaniel Eklöf2020-08-11-6/+9
| | | | timeval.tv_usec is an 'unsigned long long' on 32-bit
* ci: gitlab: let's see if we can do 32-bit buildsDaniel Eklöf2020-08-11-4/+24
|
* main: include our own bitness when logging the architectureDaniel Eklöf2020-08-11-1/+1
|
* shm: don't even try to punch a memfd hole in 32-bitDaniel Eklöf2020-08-11-0/+6
| | | | | This ensures we don't issue a warning if we fail, something that will just confuse users, as SHM scrolling is disabled in 32-bit anyway.
* Merge branch 'xmalloc-conversion' into masterDaniel Eklöf2020-08-09-65/+146
|\
| * Handle allocation failures explicitly in *_init() functionsCraig Barnes2020-08-09-4/+20
| |
| * Convert most dynamic allocations to use functions from xmalloc.hCraig Barnes2020-08-08-68/+133
|/
* changelog: add birger to 'contributers' for the upcoming releaseDaniel Eklöf2020-08-08-0/+1
|
* Merge branch 'selection-improvements' into masterDaniel Eklöf2020-08-08-32/+84
|\ | | | | | | Closes #70
| * input: motion: improve commentDaniel Eklöf2020-08-08-2/+1
| |
| * input: pointer-enter: add comment describing what we're doingDaniel Eklöf2020-08-08-0/+6
| |
| * input: motion: regression: check for RMB when updating selectionDaniel Eklöf2020-08-08-4/+6
| | | | | | | | | | | | | | | | | | | | While refactoring this code, the check for LMB or RMB got changed to LMB or "any button". This fixes that. It also adds a boolean 'cursor_is_on_grid', which should make the code easier to read and understand.
| * input: scrolling: don't send events to client if cursor is outside gridDaniel Eklöf2020-08-07-1/+8
| |
| * input: mouse: motion/enter: cleanup inside/outside grid handlingDaniel Eklöf2020-08-07-29/+49
| |
| * changelog: 'of' -> 'in'Daniel Eklöf2020-08-07-1/+1
| |
| * input: button: button events aren't passed to clients, when cursor is outside gridDaniel Eklöf2020-08-07-9/+9
| | | | | | | | | | | | | | | | | | | | Don't send mouse button escapes to a mouse grabbing client when the cursor is outside the grid (i.e. when it is inside the margins). Also don't do *any* kind of selection when the cursor is outside the grid. Previously, we only checked this for selection_start(), but e.g. double clicking would run selection_extend(), or selection_mark_word() etc.
| * input: motion: do selection update even if cursor is outside the gridDaniel Eklöf2020-08-07-9/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the selection was only updated when the mouse cursor was inside the grid. This makes it difficult to e.g. do large selections fast, since you often end up moving the cursor outside the grid, or outside the terminal window even. Now, we update the selection regardless of *where* the cursor is. This is done by bounding the row/col we pass to 'selection_update()' to the grid, while still setting the seat's row/col to -1 when the cursor is outside the grid, to ensure the xcursor etc are set correctly. Care must also be taken to *not* pass any motion events to a mouse grabbing client, when the cursor is outside the grid. Closes #70.
| * input: fix col/row calculation when cursor is in the top or left marginDaniel Eklöf2020-08-07-4/+9
| | | | | | | | | | | | | | | | | | This fixes an issue where the col/row were incorrectly set to 0 instead of -1, when the mouse cursor was inside the grid margins. This resulted in e.g. the mouse cursor having the wrong shape, and foot incorrectly handling mouse events as if they were inside the grid.
* | Merge branch 'base64' into masterDaniel Eklöf2020-08-08-5/+2
|\ \
| * | base64: simplify is_valid() by using reverse_lookup tableCraig Barnes2020-08-08-5/+2
|/ /
* | Merge branch 'attrs' into masterDaniel Eklöf2020-08-07-10/+18
|\ \ | |/ |/|
| * Replace GCC "unused" and "format" attributes with portable macrosCraig Barnes2020-08-07-10/+18
|/
* Merge branch 'syslog' into masterDaniel Eklöf2020-08-07-25/+6
|\
| * log: simplify _sys_log() functionCraig Barnes2020-08-06-25/+6
| |
* | Merge branch 'xstrndup+xrealloc' into masterDaniel Eklöf2020-08-07-0/+15
|\ \ | |/ |/|
| * xmalloc: add xrealloc() and xstrndup() functionsCraig Barnes2020-08-07-0/+15
|/
* Merge branch 'desktop-keywords' into masterDaniel Eklöf2020-08-06-0/+2
|\
| * Add keywords to desktop filesBirger Schacht2020-08-06-0/+2
| | | | | | | | | | | | | | The desktop entry specification lists 'Keywords' to acilitate searching through entries. https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html These initial values are based on the keywords from gnome-terminal.