aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeLines
...
* | | readme: clearer descriptions of secondary and tertiary DA responsesDaniel Eklöf2020-10-09-9/+5
| | |
* | | term: remove unused bit in xtsave structDaniel Eklöf2020-10-09-1/+0
|/ /
* | Merge branch 'sixel-at-scrollback-wraparound-gets-sheared' into masterDaniel Eklöf2020-10-09-190/+420
|\ \ | | | | | | | | | Closes #151
| * | changelog: we’ve fixed several sixel+reflow related bugsDaniel Eklöf2020-10-09-0/+2
| | |
| * | sixel: reflow: drop sixels that crosses the scrollback history’s endDaniel Eklöf2020-10-09-0/+23
| | | | | | | | | | | | | | | This fixes various crashes that occurred after a reflow due to the sixel image list invariants no longer being true.
| * | sixel: unhook: do overwrite *after* linefeedingDaniel Eklöf2020-10-09-2/+5
| | | | | | | | | | | | | | | This ensures the overwrite is done when the scrollback history is in the same state as when we then insert the new image.
| * | sixel: overwrite: use pixman to calculate new the sixel boundariesDaniel Eklöf2020-10-09-75/+74
| | | | | | | | | | | | | | | | | | When punching a hole in a sixel (and thus splitting it up into up to four new sixels), use pixman to calculate the new sixel coordinates and sizes.
| * | sixel: ovewrite-by-rectangle: in debug builds, cross-reference against pixmanDaniel Eklöf2020-10-09-2/+38
| | | | | | | | | | | | | | | Use pixman to calculate the intersection of the rectangle being overwritten, and the sixel(s). Verify our code matches.
| * | sixel: verify scrollback consistency: new verify functionDaniel Eklöf2020-10-09-0/+26
| | | | | | | | | | | | Verifies sixels have been scrolled out correctly
| * | sixel: add comments to verify_*() functionsDaniel Eklöf2020-10-09-0/+23
| | |
| * | sixel: verify-*: don’t return anything; rely on asserts onlyDaniel Eklöf2020-10-09-18/+7
| | |
| * | sixel: scroll up/down: early return when list is emptyDaniel Eklöf2020-10-09-0/+6
| | | | | | | | | | | | Branch tagged as ‘likely’ for performance reason
| * | sixel: cell-size-changed: don’t verify sixels hereDaniel Eklöf2020-10-09-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The state after this function is an intermediate state and isn’t necessarily valid. This sixels needs to be ‘reflowed’ to ensure a valid state. This is something that should be done by the caller after the text grid has been reflowed and the sixel coordinates have been re-mapped to the new grid. TODO: can/should we update the sixel cols/rows in sixel_reflow() instead?
| * | sixel: unhook: look total number of sixelsDaniel Eklöf2020-10-09-0/+3
| | | | | | | | | | | | | | | This helps debug sixel overwrites, as it makes it more visible when there are sixels that _should_ have been removed.
| * | sixel: scroll-up: don’t break out early of loopDaniel Eklöf2020-10-09-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This function loops the list of sixels, and discards those that would be scrolled out if the grid offset is moved forward by the specified number of rows. The criteria is when the rebased row value is less than the number of rows to scroll. A rebased row number is a zero-based number starting at the beginning of the scrollback. Thus, when scrolling 5 rows, rows with a rebased row number between 0-4 will be scrolled out. For performance reasons, we used to break out of the loop as soon as a row number *larger* than the scroll count. This however does not work. The sixels are sorted by their *end* row. While this works in most cases (think images outputted in the shell in the normal screen), it doesn’t always. In the alt screen, where applications can print images just about anywhere, it is possible to have *any* start row number anywhere in the sixel list. Just as long as their *end* row numbers are sorted. For example, a huuuge sixel that covers the entire scrollback. This sixel will naturally be first in the list (and thus sixel_scroll_up() will visit it *last*, since it iterates the list in reverse), but should still be destroyed when scrolling.
| * | sixel: verify-list-order: add an ‘index’ variableDaniel Eklöf2020-10-09-0/+4
| | | | | | | | | | | | This will make it easier when debugging assertions in this function.
| * | sixel: overwrite-by-rectangle: assert sixels don’t cross scrollback wrap-aroundDaniel Eklöf2020-10-09-4/+7
| | |
| * | sixel: scroll: call sixel_erase() instead of sixel_destroy()Daniel Eklöf2020-10-09-2/+2
| | | | | | | | | | | | | | | This ensures the screen is updated correctly. Without this, the sixel image would remain on screen until force-refreshed by some other means.
| * | sixel: TOOD -> TODO (fixes codespell build error)Daniel Eklöf2020-10-09-1/+1
| | |
| * | sixel: verify-no-overlap: free pixman regionsDaniel Eklöf2020-10-09-0/+5
| | |
| * | sixel: verify-no-overlap: initialize ‘intersection’ pixman regionDaniel Eklöf2020-10-09-0/+1
| | |
| * | render: resize: call sixel_reflow() after reflowing gridsDaniel Eklöf2020-10-09-0/+3
| | |
| * | sixel: unhook: only call render_refresh() onceDaniel Eklöf2020-10-09-2/+3
| | |
| * | sixel: implement reflowDaniel Eklöf2020-10-09-54/+51
| | | | | | | | | | | | | | | | | | | | | Move sixel reflow from grid_reflow() to sixel_reflow(). This lets us use internal sixel functions to update the sixels. Note that grid_reflow() still needs to remap the sixelss coordinates.
| * | term: update sixel rows/cols *after* cell dimension change, *before* resizeDaniel Eklöf2020-10-09-39/+27
| | | | | | | | | | | | | | | This fixes an issue where we resized+reflowed with bad rows/cols values in the sixels.
| * | sixel: verify-sixels: check for bad list order lastDaniel Eklöf2020-10-09-2/+2
| | |
| * | sixel: verify-no-wraparound-crossover: fix calculation of ‘end’ rowDaniel Eklöf2020-10-09-1/+1
| | |
| * | sixel: add sixel_cell_size_changed()Daniel Eklöf2020-10-09-0/+25
| | | | | | | | | | | | | | | This function should be called *after* the cell dimensions have changed, but *before* resizing/reflowing the grids.
| * | sixel: debug: more fine-grained verification of sixel image listDaniel Eklöf2020-10-09-5/+63
| | | | | | | | | | | | | | | * Verify no sixel crosses the scrollback wrap-around * Verify no sixels overlap
| * | grid: reflow: re-insert sixels *after* new grid offset has been setDaniel Eklöf2020-10-09-40/+51
| | | | | | | | | | | | | | | | | | Also make sure to destroy sixels that are too big to fit in the scrollback. Fixes issues with the sixel list not being sorted correctly.
| * | sixel: overwrite: calculate split-up image pieces’ rows/cols from their width/heightDaniel Eklöf2020-10-09-8/+3
| | |
| * | sixel: overwrite: remove assertsDaniel Eklöf2020-10-09-12/+1
| | | | | | | | | | | | Sixels may extend outside the visible screen area
| * | term: re-calculate sixel images’ rows/cols values when cell size changesDaniel Eklöf2020-10-09-0/+14
| | |
| * | sixel: fix sheared image when image crosses scrollback wrap-aroundDaniel Eklöf2020-10-09-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a sixel image crosses the scrollback wrap-around, it is split up into (at least) two pieces. We use cursor->point.col for all pieces’ x-coordinate. This caused the final image to appear sheared, since we do a carriage-return (after a number of linefeeds) after each piece - this causes the cursor’s position to be reset to the left margin. The solution is simple; remember the cursor’s initial x-coordinate, and use that to position all image pieces. Closes #151.
| * | sixel: overwrite-by-rectangle expects ‘width’ to not exceed screenDaniel Eklöf2020-10-09-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | This fixes a crash when the emitted sixel extends beyond the right margin. The crash only happens when there are other sixel images already emitted. Fixes part of #151
| * | sixel: fold long lineDaniel Eklöf2020-10-09-1/+3
|/ /
* | Merge branch 'bell-triggers-faked-urgency' into masterDaniel Eklöf2020-10-09-2/+98
|\ \ | | | | | | | | | Closes #157
| * | doc: foot.ini: bell/urgency: add note about this getting replaced in the futureDaniel Eklöf2020-10-09-1/+4
| | | | | | | | | | | | | | | | | | | | | The ‘set-urgency’ action is an interim workaround for lack of support of an urgency hint in Wayland compositors. If/when such a feature gets implemented in Wayland, I intend to use that instead of the current implementation in foot.
| * | bell: optionally render margins in red when receiving BELDaniel Eklöf2020-10-08-2/+95
|/ / | | | | | | | | | | | | | | | | | | | | Add anew config option, ‘bell=none|set-urgency’. When set to ‘set-urgency’, the margins will be painted in red (if the window did not have keyboard focus). This is intended as a cheap replacement for the ‘urgency’ hint, that doesn’t (yet) exist on Wayland. Closes #157
* | doc: foot.1: remove ‘--’ from example command lineDaniel Eklöf2020-10-08-1/+1
| |
* | doc: foot.ini: mention that ‘lines’ is rounded up to nearest power of 2Daniel Eklöf2020-10-08-1/+3
| |
* | doc: foot.ini: “top at” -> “top of”Daniel Eklöf2020-10-08-1/+1
| |
* | doc: foot.ini: it’s foot.ini, not foot.initDaniel Eklöf2020-10-08-1/+1
| |
* | render: apply opacity correctly when in reverse video modeDaniel Eklöf2020-10-08-2/+9
| |
* | changelog: fix CSI escape sequenceDaniel Eklöf2020-10-08-1/+1
| |
* | doc: foot.ini: the tweak section is called ‘tweak’, not ‘tweaks’Daniel Eklöf2020-10-07-1/+1
| |
* | config: ignore key/value pairs following an invalid section nameDaniel Eklöf2020-10-07-0/+9
| | | | | | | | | | | | | | | | | | | | | | When we detected an invalid section name, we correctly logged this and warned the user. However, the internal state machine now had an invalid section enum value. This caused a crash when the next key/value pair was to be parsed and we tried to lookup which parser function to call. Closes #159.
* | readme: add link to the ‘Performance’ page on the wikiDaniel Eklöf2020-10-06-1/+2
| |
* | term: cursor-left: unlikely -> likely for reverse-wrapDaniel Eklöf2020-10-06-1/+1
| | | | | | | | | | Since reverse wrap-around is enabled by default, we’re *likely* to take this branch.
* | Merge branch 'reverse-wrap' into masterDaniel Eklöf2020-10-06-4/+60
|\ \ | | | | | | | | | Closes #150
| * | term: enable reverse wrap-around by defaultDaniel Eklöf2020-10-06-2/+6
| | | | | | | | | | | | | | | Since we’re now doing reverse auto-wrapping by default, we add ‘bw’ (‘auto_left_margin’)to terminfo.
| * | csi: xtrestore: add ‘reverse wrap’Daniel Eklöf2020-10-03-0/+1
| | |
| * | term: cursor-left: don’t do reverse-wrapping unless auto-margins are enabledDaniel Eklöf2020-10-03-1/+1
| | | | | | | | | | | | This matches XTerm’s behavior.
| * | changelog: reverse auto-wrapDaniel Eklöf2020-10-02-0/+6
| | |
| * | vt: BS: *only* reset lcf if cursor is beyond right margin: don’t move cursorDaniel Eklöf2020-10-02-1/+4
| | | | | | | | | | | | | | | This is needed to make reverse auto-wrap work correctly. Without it, we’ll end up moving the cursor left one cell extra.
| * | term: cursor-left: reverse-wrap when cursor is at the left marginDaniel Eklöf2020-10-02-3/+38
| | | | | | | | | | | | Assuming the private mode ‘reverse-wrap’ has been enabled.
| * | term: add private mode flag ‘’reverse-wrap’Daniel Eklöf2020-10-02-0/+7
| | |
* | | doc: benchmark: update with ‘laptop’ results after 1.5 releaseDaniel Eklöf2020-10-03-9/+8
|/ /
* | Revert "term: cursor-left: reduce move count by one when lcf=true"Daniel Eklöf2020-10-02-7/+0
| | | | | | | | | | | | | | This reverts commit 02e3e4ac9b2703a0a867211c2482eab257cbc311. This broke at least Emacs. Cursor movement at the margins *is* undefined, and the behavior we’re now reverting to matches XTerm.
* | term: cursor-left: reduce move count by one when lcf=trueDaniel Eklöf2020-10-01-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | When lcf is true, cursor is actually beyond the right margin, but the stored coordinate is at the margin. This means we need to reduce the number of cells to move the cursor by one. This fixes an issue where e.g. backspacing when the cursor is at the right margin erased the next-to-last character instead of the last character.
* | changelog: trackpad scrolling: ‘multiplier’ is in the ‘scrollback’ sectionDaniel Eklöf2020-09-29-2/+2
| |
* | Merge branch 'trackpad-scroll-speed' into masterDaniel Eklöf2020-09-29-7/+25
|\ \ | | | | | | | | | Closes #144
| * | changelog: multiplier: the option belongs to the ‘scrollback’ sectionDaniel Eklöf2020-09-29-2/+2
| | |
| * | changelog: multiplier default value changed from 1.0 -> 3.0Daniel Eklöf2020-09-29-0/+5
| | |
| * | config: change default multiplier from 1.0 -> 3.0Daniel Eklöf2020-09-29-3/+3
| | |
| * | changelog: reword trackpad scrolling speed entryDaniel Eklöf2020-09-29-0/+5
| | |
| * | input: trackpad scroll: correctly convert pixel movements to line movementsDaniel Eklöf2020-09-29-4/+12
|/ / | | | | | | | | | | | | | | | | | | | | | | Trackpad scroll movements are in pixels. Foot previously “translated” these directly to line movements (i.e. a one pixel scroll event was translated into a one line scroll). Now we use the line height of the terminal and correctly convert pixels to lines. This makes the trackpad scroll speed in foot consistent with the scroll speed in e.g. Alacritty and Kitty.
* | Merge branch 'reflow-retain-scrollback-position' into masterDaniel Eklöf2020-09-29-1/+28
|\ \ | | | | | | | | | Closes #142
| * | grid: reflow: fix release build; ‘idx’ is only used in an assert()Daniel Eklöf2020-09-29-1/+2
| | |
| * | grid: reflow: handle viewport being too far down when enlarging the windowDaniel Eklöf2020-09-29-2/+17
| | | | | | | | | | | | | | | | | | If the viewport is close to the bottom, but not *at* the bottom, and we’re enlarging the window, the translated viewport will be too far down.
| * | grid: reflow: retain scrollback positionDaniel Eklöf2020-09-29-1/+12
|/ / | | | | | | Closes #142
* | Merge branch 'osc4-refresh-scheduling' into masterDaniel Eklöf2020-09-29-33/+32
|\ \ | | | | | | | | | Closes #141
| * | changelog: fixed color flashes with OSC 4,10,11Daniel Eklöf2020-09-29-0/+2
| | |
| * | render: remove render_refresh_margins()Daniel Eklöf2020-09-29-9/+0
| | |
| * | osc: don’t explicitly call render_refresh() when changing the color paletteDaniel Eklöf2020-09-29-9/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Doing so will schedule the renderer “as soon as possible”. I.e we’re by-passing the regular scheduler, and thus we’re by-passing the user’s setting of the delayed-render-* timers. The fact that we’re scheduling “as soon as possible” also means we’re much more likely to trigger flickering, or color flashes, if the application is changing colors which are on the screen. To handle changes to the cursor color(s), use the new term_damage_cursor() instead of render_refresh(). To handle background color changes, which affect the margins, use the new term_damage_margins() instead of render_refresh_margins(), Closes #141
| * | render: term->render.margins is used to explicitly tell us to re-render marginsDaniel Eklöf2020-09-29-15/+7
| | |
| * | term: add term_damage_cursor() and term_damage_margins()Daniel Eklöf2020-09-29-0/+18
|/ / | | | | | | | | | | | | | | | | term_damage_cursor() damages the cell where the cursor is currently at. This can be used to ensure the cursor is re-drawn, if there aren’t any other pending updates. term_damage_margins() requests the margins be redrawn the next time we render the grid.
* | Merge branch 'allow-mouse-binding-click-count-less-than' into masterDaniel Eklöf2020-09-27-6/+25
|\ \
| * | input: mouse: match binding if binding’s click count is *less*Daniel Eklöf2020-09-27-6/+25
|/ / | | | | | | | | | | | | | | | | | | | | Allow a mouse binding to match even if its click count is less than the actual click count. If there are multiple bindings that match, use the one with the highest click count (that less than, or equal to the actual click count). Closes #146
* | install: say _why_ ncurses and scdoc is neededDaniel Eklöf2020-09-24-2/+2
| |
* | Revert "meson: add -Dwith-docs=disabled|enabled|auto"Daniel Eklöf2020-09-24-25/+11
| | | | | | | | This reverts commit 9d6b2c934222f7e492fba06d02dd2d5991814d1b.
* | Merge branch 'make-doc-generation-optional' into masterDaniel Eklöf2020-09-24-11/+25
|\ \
| * | meson: add -Dwith-docs=disabled|enabled|autoDaniel Eklöf2020-09-24-11/+25
|/ / | | | | | | | | | | | | | | | | | | | | When enabled, man pages are generated and installed, along with README.md, CHANGELOG.md and LICENSE. This requires ‘scdoc’ as a make dependency. When disabled, ‘scdoc’ is no longer required, no man pages will be built, and no documentation at all is installed. Defaults to ‘enabled’.
* | changelog: add new ‘unreleased’ sectionDaniel Eklöf2020-09-18-0/+12
| |
* | Merge branch 'releases/1.5' into masterDaniel Eklöf2020-09-18-6/+4
|\|
| * meson/pkgbuild: bump version to 1.5.01.5.0Daniel Eklöf2020-09-18-2/+2
| |
| * changelog: prepare for 1.5.0Daniel Eklöf2020-09-18-4/+2
|/
* changelog: add cherti to contributorsDaniel Eklöf2020-09-18-0/+1
|
* Revert "changelog: add cherti to contributors"Daniel Eklöf2020-09-18-3/+4
| | | | This reverts commit 8f3692f9a662c69cadca1b840f22f4f222b550e9.
* changelog: add cherti to contributorsDaniel Eklöf2020-09-18-4/+3
|
* meson/pkgbuild: bump fcft requirement to 2.3.0Daniel Eklöf2020-09-18-2/+2
|
* selection: reset clipboard/primary->text after free:ing itDaniel Eklöf2020-09-17-0/+2
|
* selection: primary unset: don’t free text twiceDaniel Eklöf2020-09-17-1/+0
|
* render: fix rounding errors when setting initial window size and scale != 1Daniel Eklöf2020-09-17-4/+16
| | | | | | | | | An odd cell width/height sometimes resulted in an odd grid size. Combined with a scaling factor of e.g. 2, that led to a rounding error when converting pixel sizes to logical window sizes. As a result, the _next_ configure event would cause us to loose a pixel, which led to us dropping a row from the grid.
* ci: fix path to junit report on release buildsDaniel Eklöf2020-09-16-2/+2
|
* ci: install fonts, needed for fcft testsDaniel Eklöf2020-09-16-0/+7
|
* ci: need the ‘dev’ version of ‘check’ on alpineDaniel Eklöf2020-09-16-3/+3
|
* ci: install ‘check’ - this enables fcft testsDaniel Eklöf2020-09-16-0/+4
|
* ci: repair ninja test targetDaniel Eklöf2020-09-16-1/+1
|
* ci: upload junit XML reportsDaniel Eklöf2020-09-16-1/+13
|