diff options
| author | Craig Barnes <craigbarnes@protonmail.com> | 2022-02-12 12:04:57 +0000 |
|---|---|---|
| committer | Craig Barnes <craigbarnes@protonmail.com> | 2022-02-12 12:26:42 +0000 |
| commit | 23cf80667a36aaff1865fc50afab3f98a796cf14 (patch) | |
| tree | 92970245488cdd76c0fe06eb93d1b2d15f8007fe /spawn.c | |
| parent | osc: don’t damage the entire view on a single color palette update (diff) | |
Explicitly initialize sigaction::sa_mask members with sigemptyset(3)
Not doing so before calling sigaction(3) is "undefined" according to
POSIX[1]:
> Applications shall call either sigemptyset() or sigfillset() at least
> once for each object of type sigset_t prior to any other use of that
> object. If such an object is not initialized in this way, but is
> nonetheless supplied as an argument to any of pthread_sigmask(),
> sigaction(), sigaddset(), sigdelset(), sigismember(), sigpending(),
> sigprocmask(), sigsuspend(), sigtimedwait(), sigwait(), or
> sigwaitinfo(), the results are undefined.
The use of designated initializers means that sa_mask members were
still being initialized, but sigset_t is an opaque type and implicit
initialization doesn't necessarily produce the same results as using
sigemptyset(3) (although it typically does on most implementations).
[1]: https://pubs.opengroup.org/onlinepubs/9699919799/functions/sigaddset.html
Diffstat (limited to 'spawn.c')
| -rw-r--r-- | spawn.c | 4 |
1 files changed, 3 insertions, 1 deletions
@@ -45,7 +45,9 @@ spawn(struct reaper *reaper, const char *cwd, char *const argv[], goto child_err; /* Restore ignored (SIG_IGN) signals */ - if (sigaction(SIGHUP, &(struct sigaction){.sa_handler = SIG_DFL}, NULL) < 0) + struct sigaction dfl = {.sa_handler = SIG_DFL}; + sigemptyset(&dfl.sa_mask); + if (sigaction(SIGHUP, &dfl, NULL) < 0) goto child_err; if (cwd != NULL && chdir(cwd) < 0) { |
